New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump evohome-async to 0.4.4 #103084
Bump evohome-async to 0.4.4 #103084
Conversation
… evo_new_library
What this integration needs is a config entry indeed and tests. |
Yes - the goal is to add config entry. Will need to refactor the broker first (see: #79869).
There are no breaking changes for the user (as indicated above), except that thrown exceptions will be different (different name, message). The messages with the exceptions are more helpful. Specifically, there are no mention of the exceptions in the docs, so nothing to update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
Thnx @zxdavb 👍
Client library bumped to 0.4.4 - no changes to integration, other than manifest.json. Change include:
|
TL;DR: Can I Merge this? I have read the Perfect PR recommendations, but the next steps are not clear to me... This PR has been reviewed, and passes all tests. Specifically, can I press this button I see: Squash and merge, or is that not allowed? I have another PR queued up, is all. If this question is inappropriate, please let me know (gently). |
I'll merge it after the CI tests pass |
Proposed change
This PR upgrades the evohome client library (evohome-async) and makes the minimum necessary changes to the integration codebase so that existing functionality is preserved.
The differences between the old library, and the refactored library are quite extensive: zxdavb/evohome-async@0.3.15...0.4.4
In particular, the client library no longer raises generic exceptions (e.g.
KeyError
,aiohttp.ClientResponseError
) and instead raises its own exceptions (e.g.evo.exceptions.AuthenticationFailed
).This PR is expected to be the first of a sequence of such to improve the code quality of evohome, such as type hints, and to eventually add in config flow.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: