Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race in starting reauth flows #103130

Merged
merged 3 commits into from Oct 31, 2023
Merged

Fix race in starting reauth flows #103130

merged 3 commits into from Oct 31, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 31, 2023

Proposed change

Fix a race stating reauth flows
Screenshot 2023-10-31 at 10 03 35 AM

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much better 👍

homeassistant/config_entries.py Show resolved Hide resolved
@bdraco bdraco marked this pull request as ready for review October 31, 2023 16:48
@bdraco bdraco requested a review from a team as a code owner October 31, 2023 16:48
@bdraco
Copy link
Member Author

bdraco commented Oct 31, 2023

test failure is unrelated

FAILED tests/components/fritz/test_update.py::test_available_update_can_be_installed - AssertionError: assert 'unavailable' == 'on'

@bdraco
Copy link
Member Author

bdraco commented Oct 31, 2023

mysql timeout test failure is unrelated

@bdraco bdraco merged commit 9b27552 into dev Oct 31, 2023
47 of 49 checks passed
@bdraco bdraco deleted the fix_race_reauth_2 branch October 31, 2023 17:38
frenck pushed a commit that referenced this pull request Oct 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants