Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid UDP discovery when setting up tplink devices #103150

Closed
wants to merge 4 commits into from

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 31, 2023

Proposed change

By saving and passing the device type to connect_single, we can avoid an update cycle, and UDP discovery which should improve reliability for networks where UDP is a problem or the device times out getting connected.

needs python-kasa/python-kasa#538

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @rytilahti, @TheGardenMonkey, mind taking a look at this pull request as it has been labeled with an integration (tplink) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tplink can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tplink Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@rytilahti
Copy link
Member

rytilahti commented Nov 1, 2023

If wanted, we could convert to the integration to use connect_single already prior the linked PR gets merged and released. That won't get us rid off that unnecessary query for discovering the device type, but it would move the integration away from the non-discovery UDP comms, right?

@bdraco
Copy link
Member Author

bdraco commented Nov 1, 2023

Sadly we can't because of the bug with the power strips (where we don't update once with the correct device type) seen in the other PR

@bdraco
Copy link
Member Author

bdraco commented Nov 19, 2023

going to rework this based on the feedback in python-kasa/python-kasa#538 and will open a new pr

@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2023
@bdraco bdraco deleted the tplink_save_device_class branch February 24, 2024 21:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants