New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid UDP discovery when setting up tplink devices #103150
Conversation
Hey there @rytilahti, @TheGardenMonkey, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
If wanted, we could convert to the integration to use |
Sadly we can't because of the bug with the power strips (where we don't update once with the correct device type) seen in the other PR |
going to rework this based on the feedback in python-kasa/python-kasa#538 and will open a new pr |
Proposed change
By saving and passing the device type to
connect_single
, we can avoid an update cycle, and UDP discovery which should improve reliability for networks where UDP is a problem or the device times out getting connected.needs python-kasa/python-kasa#538
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: