Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve HomeKit description of what the PIN looks like #103170

Merged
merged 2 commits into from Nov 7, 2023

Conversation

gladhorn
Copy link
Contributor

@gladhorn gladhorn commented Nov 1, 2023

This would have saved me an hour of searching and wondering. Many homekit devices have the code next to the barcode it seems.

Breaking change

Proposed change

Add more information how to add homekit devices.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

This would have saved me an hour of searching and wondering.
Many homekit devices have the code next to the barcode it seems.
@home-assistant
Copy link

home-assistant bot commented Nov 1, 2023

Hey there @Jc2k, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (homekit_controller) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of homekit_controller can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign homekit_controller Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@gladhorn
Copy link
Contributor Author

gladhorn commented Nov 1, 2023

See also #67451

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gladhorn

@Jc2k
Copy link
Member

Jc2k commented Nov 1, 2023

Maybe the docs could be updated to have examples of the different common stickers. I think older devices don't have the QR code and have the code with dashes in. Newer devices have the type with barcodes and they don't have dashes.

@bdraco
Copy link
Member

bdraco commented Nov 1, 2023

@MartinHjelmare MartinHjelmare changed the title HomeKit: improve description of what the PIN looks like Improve HomeKit description of what the PIN looks like Nov 1, 2023
@frenck frenck merged commit 41a235b into home-assistant:dev Nov 7, 2023
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants