New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add duotecno OFF hvac mode #103223
Add duotecno OFF hvac mode #103223
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of this there was no way to turn the climate entity completely off, this fixes the problem by adding the OFF preset.
This sounds like a workaround, as this will result in turning off the whole thing?
Shouldn't it be implementing the on/off services and reflect the HVAC state correctly instead?
Also, thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:
- A link to the release notes of this package version, and all versions in between.
- A link to the changelog of this package.
- A link to a Git(Hub) diff/compare view from the current version to the bumped version.
This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.
Thanks already! 👍
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
I added the links (forgot this as this is not pure a dependancy bump PR). Hmm not sure if i understand how we can implement the on/off state in the Climate entity Reading this docu i can only think to get this to work woth 2 hvac modes:
but by doing it this way we lsoe the visibility if the device is heating/cooling |
Correct, it needs to be handled via a HVAC mode, not presets as done in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Cereal2nd 👍
../Frenck
Proposed change
When implementing duotecno there is one preset that was missed, the 'off preset'
Duotecno does not allow you to control the hvac modes, these are handled internally in the modules, so the hvac modes are just to display info.
Because of this there was no way to turn the climate entity completely off, this fixes the problem by adding the OFF preset.
Users reported this problem, so it would be nice to add it to the next maintenance release.
dependancy upgrade links:
https://github.com/Cereal2nd/pyDuotecno/releases/tag/2023.11.0
https://github.com/Cereal2nd/pyDuotecno/releases/tag/2023.11.1
Cereal2nd/pyDuotecno@2023.10.1...2023.11.1
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: