Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug logging for which adapter is used to connect bluetooth devices #103264

Merged
merged 1 commit into from Nov 3, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 2, 2023

Proposed change

This is a debug logging improvement to help users find problems with their setup

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

This is a debug logging improvement to help users find problems
with their setup
@bdraco bdraco changed the title Log which adapter is used to connect bluetooth devices Add debug logging for which adapter is used to connect bluetooth devices Nov 2, 2023
Copy link
Member

@jpbede jpbede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this and it works as expected. Thank you 👍.

@bdraco
Copy link
Member Author

bdraco commented Nov 2, 2023

Thanks for testing 👍

@jpbede jpbede merged commit c81ada1 into dev Nov 3, 2023
52 of 53 checks passed
@jpbede jpbede deleted the bluetooth_logging_wrap branch November 3, 2023 06:35
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2023
@frenck frenck added this to the 2023.11.3 milestone Nov 22, 2023
@frenck
Copy link
Member

frenck commented Nov 22, 2023

Picked this into the milestone, as it resolved a merge conflict with #104150

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants