Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace/restructure HomeWizard device fixtures to reflect reality #103311

Merged
merged 7 commits into from Nov 4, 2023
Merged

Replace/restructure HomeWizard device fixtures to reflect reality #103311

merged 7 commits into from Nov 4, 2023

Conversation

frenck
Copy link
Member

@frenck frenck commented Nov 3, 2023 •
edited

Proposed change

Adjusts the device fixtures structure of HomeWizard, to allow a correct set of fixtures to be provided for each specific device.

This is done by introducing a set of fixtures per device/model/situation. This move is needed to be able to test entities/situations for specific devices in follow-up PRs.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Nov 3, 2023

Hey there @DCSBL, mind taking a look at this pull request as it has been labeled with an integration (homewizard) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of homewizard can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign homewizard Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@frenck frenck marked this pull request as ready for review November 3, 2023 14:42
DCSBL
DCSBL approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@DCSBL DCSBL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only one small remark but I don't think it is an issue.

tests/components/homewizard/test_switch.py
@@ -26,7 +26,7 @@
]


@pytest.mark.parametrize("device_fixture", ["device-HWE-SKT.json"])
@pytest.mark.parametrize("device_fixture", ["HWE-SKT"])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this adds anything useful, but HWE-P1, SDM230/SDM630 also support cloud_enabled.

Copy link
Member Author

@frenck frenck Nov 3, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to not to broaden the scope of this PR. As in, the fixtures can be extended, and the tests as well. But the changeset is already quite large :)

Kane610
Kane610 approved these changes Nov 4, 2023
View reviewed changes
Copy link
Member

@Kane610 Kane610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, noticed one small addition I just wanted to point out.

tests/components/homewizard/test_diagnostics.py
@pytest.mark.parametrize(
"device_fixture", ["device-HWE-P1.json", "device-HWE-SKT.json"]
)
@pytest.mark.parametrize("device_fixture", ["HWE-P1", "HWE-SKT", "SDM230"])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SDM230 wasn't part of this before.

Copy link
Member Author

@frenck frenck Nov 4, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is fine, it was more added to put the fixture to use :)
The output is almost the same as HWE-SKT (which is now more pure and thus misses a case), thus, the SDM230 was added here to keep test coverage at full.

Previously the fixture haven't been actually reflecting their devices, now they do.

@frenck frenck merged commit 109944e into dev Nov 4, 2023
23 checks passed
@frenck frenck deleted the frenck-2023-1368 branch November 4, 2023 12:37
@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Kane610 Kane610 Kane610 approved these changes

@DCSBL DCSBL DCSBL approved these changes

Assignees
No one assigned
Labels
cla-signed code-owner-approved code-quality has-tests integration: homewizard Quality Scale: platinum small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@frenck @Kane610 @DCSBL