Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle UniFi traffic rules not supported on older versions #103346

Merged
merged 1 commit into from Nov 4, 2023

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Nov 3, 2023

Breaking change

Proposed change

Don't cancel UniFi initialise on errors
Kane610/aiounifi@v64...v65

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco
Copy link
Member

bdraco commented Nov 4, 2023

It would be nicer if Kane610/aiounifi@v64...v65#diff-337a9fb8934de299dd2b73f984e86594251476b3de9893e4b777d9e1a772e8e2R78 logged the error instead of swallowing them

@Kane610
Copy link
Member Author

Kane610 commented Nov 4, 2023

It would be nicer if Kane610/aiounifi@v64...v65#diff-337a9fb8934de299dd2b73f984e86594251476b3de9893e4b777d9e1a772e8e2R78 logged the error instead of swallowing them

I agree. Will fix that later. Was tired and I just wanted to try to get this in for 11.1

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Kane610 👍

../Frenck

@frenck frenck merged commit 22be56a into home-assistant:dev Nov 4, 2023
53 checks passed
@frenck frenck mentioned this pull request Nov 4, 2023
@Kane610 Kane610 deleted the unifi-bump_to_v65 branch November 4, 2023 12:28
@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unifi integration stopped working in core 2023.11.0
3 participants