Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OurGroceries integration #103387

Merged
merged 6 commits into from Nov 26, 2023
Merged

Add OurGroceries integration #103387

merged 6 commits into from Nov 26, 2023

Conversation

OnFreund
Copy link
Contributor

@OnFreund OnFreund commented Nov 4, 2023 •
edited

Proposed change

Add an integration with OurGroceries and expose shopping lists as Todo entities.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

joostlek
joostlek requested changes Nov 4, 2023
View reviewed changes
homeassistant/components/ourgroceries/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/ourgroceries/coordinator.py Outdated Show resolved Hide resolved
homeassistant/components/ourgroceries/manifest.json Outdated Show resolved Hide resolved
tests/components/ourgroceries/test_config_flow.py Outdated Show resolved Hide resolved
tests/components/ourgroceries/test_config_flow.py Show resolved Hide resolved
homeassistant/components/ourgroceries/__init__.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft November 4, 2023 17:33
@home-assistant
Copy link

home-assistant bot commented Nov 4, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@OnFreund OnFreund marked this pull request as ready for review November 4, 2023 17:48
joostlek
joostlek requested changes Nov 4, 2023
View reviewed changes
homeassistant/components/ourgroceries/todo.py Show resolved Hide resolved
tests/components/ourgroceries/conftest.py Outdated Show resolved Hide resolved
tests/components/ourgroceries/test_coordinator.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft November 4, 2023 19:04
@OnFreund OnFreund marked this pull request as ready for review November 4, 2023 19:45
This was referenced Nov 5, 2023
Merged
Merged
@OnFreund
Copy link
Contributor Author

@joostlek are there any additionally required changes?

@OnFreund
Copy link
Contributor Author

@joostlek is there anything still missing here? I'd love to get this merged in time for the beta

joostlek
joostlek requested changes Nov 24, 2023
View reviewed changes
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final remarks

homeassistant/components/ourgroceries/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/ourgroceries/todo.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft November 24, 2023 13:32
@OnFreund OnFreund marked this pull request as ready for review November 24, 2023 16:05
@OnFreund
Copy link
Contributor Author

The test failures are in different integrations and don't seem related to this PR

@OnFreund
Copy link
Contributor Author

After a rebase (no additional changes) the tests pass. Are we good to get this merged?
Thanks!

@joostlek
Copy link
Member

I'll take another look when I get home.

@joostlek joostlek merged commit 6e5dfa0 into home-assistant:dev Nov 26, 2023
53 checks passed
@OnFreund OnFreund deleted the ourgroceries branch November 26, 2023 16:45
MartinHjelmare
MartinHjelmare reviewed Nov 27, 2023
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comments in a new PR. Thanks!

homeassistant/components/ourgroceries/strings.json Show resolved Hide resolved
homeassistant/components/ourgroceries/todo.py Show resolved Hide resolved
homeassistant/components/ourgroceries/coordinator.py Show resolved Hide resolved
@OnFreund OnFreund mentioned this pull request Nov 27, 2023
Merged
20 tasks
@OnFreund
Copy link
Contributor Author

Thanks @MartinHjelmare. I addressed those in #104606.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare left review comments

@joostlek joostlek joostlek approved these changes

Assignees
No one assigned
Labels
cla-signed has-tests integration: ourgroceries new-integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@OnFreund @joostlek @MartinHjelmare