New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Prusa Link to new Digest Authentication and /v1/ API #103396
Conversation
Hey there @balloob, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
From
The Prusa api versioning is a bit mess they advertise different numbers on MINI/MK4/XL/PrusaLink(RaspberryPi), thats why checking EDIT: After some digging I think, that buddy FW MINI/MK3.5/MK4 will report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure CI is passing
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Would it be possible to use the old API for this endpoint? So we can avoid the breaking change? |
I've re-added the Material sensor using the old API. So the only breaking change is now the Enum in the printer.state sensor. |
Co-authored-by: Robert Resch <robert@resch.dev>
Co-authored-by: Robert Resch <robert@resch.dev>
Implemented all review suggestions. Thanks @edenhaus! |
Co-authored-by: Robert Resch <robert@resch.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Skaronator 👍
Test failure unrelated: |
Awesome thanks for the review! |
Breaking change
Proposed change
This PR updates pyprusalink library.
Tested with my XL on 5.1 firmware
New Attention Status:
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: