Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin jaraco.functools to fix builds and CI #103406

Merged
merged 1 commit into from Nov 4, 2023
Merged

Pin jaraco.functools to fix builds and CI #103406

merged 1 commit into from Nov 4, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 4, 2023

Proposed change

builds/ci are broken due to release 4.0.0 of https://pypi.org/project/jaraco.functools/4.0.0/

abode uses an old version of jaraco.abode which relies on an old version of jaraco.functools

venv/lib/python3.12/site-packages/_pytest/assertion/rewrite.py:186: in exec_module
    exec(co, module.__dict__)
tests/components/abode/conftest.py:5: in <module>
    from jaraco.abode.helpers import urls as URL
venv/lib/python3.12/site-packages/jaraco/abode/__init__.py:5: in <module>
    from .client import Client
venv/lib/python3.12/site-packages/jaraco/abode/client.py:18: in <module>
    from .event_controller import EventController
venv/lib/python3.12/site-packages/jaraco/abode/event_controller.py:13: in <module>
    from .helpers import timeline as TIMELINE
venv/lib/python3.12/site-packages/jaraco/abode/helpers/timeline.py:6: in <module>
    from jaraco.functools import call_aside
E   ImportError: cannot import name 'call_aside' from 'jaraco.functools' (/home/runner/work/core/core/venv/lib/python3.12/site-packages/jaraco/functools/__init__.py)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

abode uses an old version of jaraco.abode which relies on an
old version of jaraco.functools
@home-assistant
Copy link

home-assistant bot commented Nov 4, 2023

Hey there @shred86, mind taking a look at this pull request as it has been labeled with an integration (abode) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of abode can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign abode Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@bdraco bdraco mentioned this pull request Nov 4, 2023
20 tasks
@bdraco bdraco changed the title Pin jaraco.functools to fix builds Pin jaraco.functools to fix builds and CI Nov 4, 2023
@joostlek
Copy link
Member

joostlek commented Nov 4, 2023

Oh whoops, did not notice that this was still a draft.

I still need to check if Pydantic is used in newer versions of jaraco.*

@bdraco
Copy link
Member Author

bdraco commented Nov 4, 2023

Only in draft because I'm waiting for a CI 👍 so approval is good if it does pass

@bdraco bdraco marked this pull request as ready for review November 4, 2023 23:38
@bdraco bdraco merged commit d3bbcbe into dev Nov 4, 2023
53 checks passed
@bdraco bdraco deleted the pin_jaraco_functools branch November 4, 2023 23:38
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants