Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update systembridgeconnector to 3.9.4 #103425

Merged
merged 4 commits into from Nov 6, 2023

Conversation

timmo001
Copy link
Contributor

@timmo001 timmo001 commented Nov 5, 2023

Proposed change

Main changes include models moving to their own package (dependency of systembridgeconnector) and the repository moving to its own repository (mainly so versions can be independent of main package).

https://github.com/timmo001/system-bridge-connector/releases/tag/3.9.4
https://github.com/timmo001/system-bridge-connector/releases

timmo001/system-bridge-connector@3.9.0...3.9.4

Type of change

  • Dependency upgrade

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@timmo001

This comment was marked as outdated.

@timmo001 timmo001 marked this pull request as draft November 5, 2023 10:29
@timmo001 timmo001 changed the title Update systembridgeconnector to 3.9.2 Update systembridgeconnector to 3.9.3 Nov 5, 2023
@timmo001

This comment was marked as outdated.

@timmo001 timmo001 changed the title Update systembridgeconnector to 3.9.3 Update systembridgeconnector to 3.9.4 Nov 5, 2023
@timmo001 timmo001 marked this pull request as ready for review November 5, 2023 12:07
Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Thnx @timmo001 👍

Copy link
Member

@jpbede jpbede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure before merging, systembridgemodels is a dependency of systembridgeconnector?

@timmo001
Copy link
Contributor Author

timmo001 commented Nov 6, 2023

Just to be sure before merging, systembridgemodels is a dependency of systembridgeconnector?

yes it is: https://github.com/timmo001/system-bridge-connector/blob/3.9.4/requirements.txt

@jpbede jpbede merged commit ad22a11 into home-assistant:dev Nov 6, 2023
53 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants