Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pycfdns from 2.0.1 to 3.0.0 #103426

Merged
merged 2 commits into from Nov 6, 2023
Merged

Bump pycfdns from 2.0.1 to 3.0.0 #103426

merged 2 commits into from Nov 6, 2023

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Nov 5, 2023

Proposed change

Bupms pycfdns from 2.0.1 to 3.0.0

This new version is a complete rewrite to better reflect the API, instead of a be a helper specific to Home Assistant. Because of that, there were several things that needed to change in the integration for it to be usable.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Nov 5, 2023

Hey there @ctalkington, mind taking a look at this pull request as it has been labeled with an integration (cloudflare) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of cloudflare can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign cloudflare Removes the current integration label and assignees on the pull request, add the integration domain after the command.

Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Thnx @ludeeus 👍

@edenhaus edenhaus merged commit 6d567c3 into dev Nov 6, 2023
53 checks passed
@edenhaus edenhaus deleted the cf_bump branch November 6, 2023 10:05
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloudflare: List index out of range
4 participants