Fix entity category for sensor fails mqtt sensor platform setup

[jbouwh]

Proposed change

This PR introduces a grace period of 3 months to allow MQTT sensors to have an invalid entity category.
It partly reverts changes make by #103210 for binary_sensor as this is also not wanted for the patch release.
#103210 disallowed sensors and binary sensors to have an entity_category set to config, this PR changes that behavior to an issue registration instead of failing setup.

Validation for entity category was added to the sensor core component #101471 but it's correct use was already communicated at october 2021.

Related: #103511

Screenshot:

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue:
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @emontnemery, mind taking a look at this pull request as it has been labeled with an integration (mqtt) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of mqtt can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign mqtt Removes the current integration label and assignees on the pull request, add the integration domain after the command.

[elupus]

I like this approach a lot. I assume it will still break due to the check in the sensor base platform component for other users. But at least handling mqtt sound like a very good approach.

Needs @frenck 's blessing thou.

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[frenck]

We haven't introduced this for binary sensors, this accidentally came in a patch release and is reverted in #103499

For just sensors, this could help (but I am not too sure if we should ship this in a patch release tbh).

[jbouwh]

We haven't introduced this for binary sensors, this accidentally came in a patch release and is reverted in #103499

For just sensors, this could help (but I am not too sure if we should ship this in a patch release tbh).

For sensor this PR might make sense as it pops out an invalid config entity_category it that is set for sensors.
But the question is indeed if it is worth time to split the implementation.

So I could take out the binary_sensor implementation part from this PR. And split it to another PR.

[jbouwh]

Removed the binary_sensor implementation to be added in a new PR #103511

[edenhaus]

Thanks @jbouwh 👍

@frenck Are you fine with shipping it with the next patch release?

[frenck]

Let's do it 👍

[frenck]

This PR conflicts with the stable release, and cannot be cleanly pulled in for patch releasing.

[jbouwh]

This PR conflicts with the stable release, and cannot be cleanly pulled in for patch releasing.

Thnx! Then well wait till the stable release.