Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump python-roborock to 0.36.0 #103465

Merged
merged 9 commits into from Nov 8, 2023
Merged

Conversation

Lash-L
Copy link
Contributor

@Lash-L Lash-L commented Nov 5, 2023

Breaking change

Proposed change

Bumps the version of python-roborock - big change was adding a py.typed file, which meant a lot more needed to be done to keep mypy happy. This is large enough of a change - it probably should be included in a major release instead of a minor so that it could be beta tested, but a minor release would be fine by me as well as everything should be fine

Also includes a added poetry.lock file to try to fix the issues with the incorrect version of dacite being installed causing issues for anyone with a custom components that requires dacite.

Changes: humbertogontijo/python-roborock@v0.35.0...v0.36.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Nov 5, 2023

Hey there @humbertogontijo, mind taking a look at this pull request as it has been labeled with an integration (roborock) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of roborock can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign roborock Removes the current integration label and assignees on the pull request, add the integration domain after the command.

homeassistant/components/roborock/select.py Outdated Show resolved Hide resolved
homeassistant/components/roborock/sensor.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft November 6, 2023 10:41
@home-assistant
Copy link

home-assistant bot commented Nov 6, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@Lash-L Lash-L marked this pull request as ready for review November 6, 2023 14:30
@Lash-L Lash-L changed the title Bump python-roborock to 0.35.4 Bump python-roborock to 0.36.0 Nov 7, 2023
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Lash-L 👍

Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lash-L Please add tests so the CI is passing after that we can merge the PR

@home-assistant home-assistant bot marked this pull request as draft November 7, 2023 08:36
@Lash-L
Copy link
Contributor Author

Lash-L commented Nov 7, 2023

@Lash-L Please add tests so the CI is passing after that we can merge the PR

Realized the code that was missing the coverage - was actually an unneeded check - so i've removed it

@Lash-L Lash-L marked this pull request as ready for review November 7, 2023 16:52
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Nov 7, 2023
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Lash-L 👍

@edenhaus edenhaus merged commit 44fe704 into home-assistant:dev Nov 8, 2023
53 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants