New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump python-roborock to 0.36.0 #103465
Bump python-roborock to 0.36.0 #103465
Conversation
Hey there @humbertogontijo, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Lash-L 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Lash-L Please add tests so the CI is passing after that we can merge the PR
Realized the code that was missing the coverage - was actually an unneeded check - so i've removed it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Lash-L 👍
Breaking change
Proposed change
Bumps the version of python-roborock - big change was adding a py.typed file, which meant a lot more needed to be done to keep mypy happy. This is large enough of a change - it probably should be included in a major release instead of a minor so that it could be beta tested, but a minor release would be fine by me as well as everything should be fine
Also includes a added poetry.lock file to try to fix the issues with the incorrect version of dacite being installed causing issues for anyone with a custom components that requires dacite.
Changes: humbertogontijo/python-roborock@v0.35.0...v0.36.0
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: