New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use right equipment identifier in DSMR setup #103494
Conversation
Hey there @RobBie1221, @frenck, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
bc26366
to
c88456a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the code coverage in the config flow
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
c88456a
to
7832b7b
Compare
The BELGIUM_EQUIPMENT_IDENTIFIER should be used as equipment identifier for 5B. As otherwise this will cause an issue when configuring the DSMR integration for 5B. This was reported in home-assistant#103233
7832b7b
to
9c97636
Compare
Breaking change
Proposed change
The BELGIUM_EQUIPMENT_IDENTIFIER should be used as equipment identifier for 5B. As otherwise this will cause an issue when configuring the DSMR integration for 5B.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: