Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use right equipment identifier in DSMR setup #103494

Merged
merged 1 commit into from Nov 6, 2023

Conversation

dupondje
Copy link
Contributor

@dupondje dupondje commented Nov 6, 2023

Breaking change

Proposed change

The BELGIUM_EQUIPMENT_IDENTIFIER should be used as equipment identifier for 5B. As otherwise this will cause an issue when configuring the DSMR integration for 5B.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Nov 6, 2023

Hey there @RobBie1221, @frenck, mind taking a look at this pull request as it has been labeled with an integration (dsmr) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of dsmr can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign dsmr Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@joostlek joostlek changed the title Use BELGIUM_EQUIPMENT_IDENTIFIER in config flow Use right equipment identifier in DSMR setup Nov 6, 2023
@joostlek joostlek added this to the 2023.11.2 milestone Nov 6, 2023
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the code coverage in the config flow

@home-assistant home-assistant bot marked this pull request as draft November 6, 2023 11:29
@home-assistant
Copy link

home-assistant bot commented Nov 6, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

The BELGIUM_EQUIPMENT_IDENTIFIER should be used as equipment identifier
for 5B. As otherwise this will cause an issue when configuring the DSMR
integration for 5B.

This was reported in home-assistant#103233
@dupondje dupondje marked this pull request as ready for review November 6, 2023 13:08
@joostlek joostlek merged commit 9118260 into home-assistant:dev Nov 6, 2023
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants