Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to Google Calendar for Web auth credentials #103570

Merged
merged 7 commits into from Nov 11, 2023

Conversation

allenporter
Copy link
Contributor

@allenporter allenporter commented Nov 7, 2023

Proposed change

Add support to Google Calendar for Web auth credentials. This means that in the future all google integrations that work on personal user data can use the same credentials, opening up the possibility for sharing credentials across integrations. This is follow up discussion from #102629 (comment)

The approach is to try attempt device auth and if it fails with invalid_client then attempt web auth. This requires minimal changes to short circuit and use the default web auth behavior with a couple of overrides in a few places in the config flow and auth implementation.

This was manually tested with web auth credentials.

We can explore actually sharing application credentials in the future. One challenge, though, is that it is difficult to tell the credential type without actually attempting to use them. For now, we record the credential type in the config entry -- this has no use now, but may be needed later to know what type of credential we have.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Nov 7, 2023
homeassistant/components/google/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/google/api.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft November 10, 2023 10:58
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@allenporter allenporter marked this pull request as ready for review November 10, 2023 16:29
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@allenporter allenporter merged commit 3f70437 into home-assistant:dev Nov 11, 2023
23 checks passed
dgomes pushed a commit to dgomes/home-assistant that referenced this pull request Nov 11, 2023
…nt#103570)

* Add support to Google Calendar for webauth credentials

* Fix broken import

* Fix credential name used on import in test

* Remove unnecessary creds domain parameters

* Remove unnecessary guard to improve code coverage

* Clarify comments about credential preferences

* Fix typo

---------

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants