Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add listeners for roborock #103651

Merged
merged 4 commits into from Nov 20, 2023

Conversation

Lash-L
Copy link
Contributor

@Lash-L Lash-L commented Nov 8, 2023

Breaking change

Proposed change

So the cloud api has a mqtt topic that we are able to subscribe to - and with that for some pieces of information, we can get an automatic update, i.e. you have an error or you start a clean or you change the fan speed.

Without the cloud api, the listeners wont do anything, but the code will still update at its normal frequency.

So we (preferably) use the local api to update on our fixed scan interval, and then we use the mqtt cloud thread to update when some things change.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Nov 8, 2023

Hey there @humbertogontijo, mind taking a look at this pull request as it has been labeled with an integration (roborock) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of roborock can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign roborock Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@Lash-L Lash-L marked this pull request as draft November 8, 2023 14:08
@Lash-L
Copy link
Contributor Author

Lash-L commented Nov 8, 2023

Marking as draft until I figure out what I want to do for pytest

@Lash-L
Copy link
Contributor Author

Lash-L commented Nov 8, 2023

My test is interesting to say the least - and I know it probably isn't ideal, but i'm not sure a better approach. I am open to suggestions.

@Lash-L Lash-L marked this pull request as ready for review November 9, 2023 21:11
Copy link
Contributor

@allenporter allenporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question below about the test approach, given its patching an internal method.

@allenporter allenporter merged commit 6ef194f into home-assistant:dev Nov 20, 2023
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants