New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add listeners for roborock #103651
Add listeners for roborock #103651
Conversation
Hey there @humbertogontijo, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Marking as draft until I figure out what I want to do for pytest |
My test is interesting to say the least - and I know it probably isn't ideal, but i'm not sure a better approach. I am open to suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a question below about the test approach, given its patching an internal method.
Breaking change
Proposed change
So the cloud api has a mqtt topic that we are able to subscribe to - and with that for some pieces of information, we can get an automatic update, i.e. you have an error or you start a clean or you change the fan speed.
Without the cloud api, the listeners wont do anything, but the code will still update at its normal frequency.
So we (preferably) use the local api to update on our fixed scan interval, and then we use the mqtt cloud thread to update when some things change.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: