Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add switch platform to V2C #103678

Merged
merged 6 commits into from Nov 9, 2023
Merged

Conversation

dgomes
Copy link
Contributor

@dgomes dgomes commented Nov 9, 2023

Proposed change

Add switch platform to V2C integration

https://github.com/dgomes/pytrydan/blob/main/CHANGELOG.md

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the dependency bump in a separate PR and leave this PR in draft until the other one is merged.

@home-assistant home-assistant bot marked this pull request as draft November 9, 2023 08:12
@home-assistant
Copy link

home-assistant bot commented Nov 9, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@edenhaus edenhaus mentioned this pull request Nov 9, 2023
20 tasks
homeassistant/components/v2c/strings.json Outdated Show resolved Hide resolved
homeassistant/components/v2c/strings.json Outdated Show resolved Hide resolved
homeassistant/components/v2c/switch.py Outdated Show resolved Hide resolved
homeassistant/components/v2c/switch.py Outdated Show resolved Hide resolved
homeassistant/components/v2c/switch.py Outdated Show resolved Hide resolved
dgomes and others added 4 commits November 9, 2023 08:50
@dgomes dgomes marked this pull request as ready for review November 9, 2023 09:56
@joostlek joostlek dismissed edenhaus’s stale review November 9, 2023 10:11

Lib bumped in separate PR

@joostlek joostlek changed the title Add switch to V2C Add switch platform to V2C Nov 9, 2023
@joostlek joostlek merged commit 4bbdf47 into home-assistant:dev Nov 9, 2023
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants