Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer IPv4 locations over IPv6 locations for upnp devices/component #103792

Merged
merged 7 commits into from Nov 13, 2023

Conversation

StevenLooman
Copy link
Contributor

Proposed change

Prefer IPv4 locations over IPv6 locations for upnp devices/component.

This requires a change to the ssdp component as well, as it has to store all known ssdp_locations in SsdpServiceInfo. I have tried to keep the changes in this component minimal, but one can argue that most passing of headers through the methods/functions should be changed by a SsdpDevice + st/dst pair.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco
Copy link
Member

bdraco commented Nov 12, 2023

Ran out of time to test today and need to sleep.

Will try to give it good test tomorrow (aka later today)

@bdraco
Copy link
Member

bdraco commented Nov 13, 2023

Pushed to my production, testing now

@bdraco
Copy link
Member

bdraco commented Nov 13, 2023

Everything seems ok on my production system.

I'm now trying it on systems with slower cpus

@bdraco
Copy link
Member

bdraco commented Nov 13, 2023

functional testing looks good.

checking performance now

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @StevenLooman

testing looks good 👍
performance looks good 👍

@bdraco bdraco merged commit 39c81cb into home-assistant:dev Nov 13, 2023
53 checks passed
@StevenLooman StevenLooman deleted the fix_102647 branch November 13, 2023 21:30
@StevenLooman
Copy link
Contributor Author

Thank you for testing and merging @bdraco!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UPnP/IGD unable to communicate with IGD at [IPv6 address]
2 participants