Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show Google Tasks that are parents and fix ordering #103820

Merged
merged 3 commits into from Nov 24, 2023

Conversation

allenporter
Copy link
Contributor

@allenporter allenporter commented Nov 11, 2023

Proposed change

Order Google Task To-do items using the server side ordering. Google Tasks that are siblings are sorted using the "position" string.

In discussion with product leads, we want to filter out child tasks and not show them since they are not supported in the UI.
A future upcoming (soon) PR will support task re-ordering. We can reconsider support for parent/child tasks in the future.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@MartinHjelmare MartinHjelmare changed the title Order Google Task To-do items using the server side ordering. Order Google Task To-do items using the server side ordering Nov 11, 2023
@allenporter
Copy link
Contributor Author

Note differing behavior in #103809 we should probably reconcile.

@allenporter allenporter marked this pull request as draft November 14, 2023 04:19
@allenporter
Copy link
Contributor Author

From an offline discussion, we've decided that we should not support child tasks.

@allenporter allenporter changed the title Order Google Task To-do items using the server side ordering Only show Google Tasks that are parents and fix ordering Nov 14, 2023
@allenporter allenporter marked this pull request as ready for review November 18, 2023 20:02
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks, @allenporter 👍

../Frenck

@frenck frenck merged commit 378a708 into home-assistant:dev Nov 24, 2023
19 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants