Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vicare volumetric flow and compressor phase sensors #103875

Merged
merged 9 commits into from Nov 14, 2023

Conversation

fb22
Copy link
Contributor

@fb22 fb22 commented Nov 12, 2023

Breaking change

Proposed change

Add diagnostic sensors compressor phase and volumetric flow to ViCare integration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @CFenner, mind taking a look at this pull request as it has been labeled with an integration (vicare) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of vicare can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign vicare Removes the current integration label and assignees on the pull request, add the integration domain after the command.

Copy link
Contributor

@CFenner CFenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution 👍
Have no heat pump to verify myself, but look good so far.

homeassistant/components/vicare/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/vicare/sensor.py Outdated Show resolved Hide resolved
Copy link
Contributor

@CFenner CFenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good, I'm just unsure about the comments I raised above.

@MartinHjelmare MartinHjelmare changed the title Add 2 heatpump sensors Add 2 vicare heatpump sensors Nov 12, 2023
@fb22
Copy link
Contributor Author

fb22 commented Nov 12, 2023

sorry, the commit Rename heatpump energy consumption sensors was meant for another PR. Don't know how to revert...

Copy link
Contributor

@CFenner CFenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fb22 please revert the unrelated change using git revert a66421affcb529f51b694d442c4d4c67c6d181d0

home-assistant[bot]

This comment was marked as outdated.

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft November 13, 2023 08:23
@fb22 fb22 marked this pull request as ready for review November 13, 2023 08:59
Copy link
Contributor

@CFenner CFenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Can someone with deeper HA knowledge look at my comments, please.

Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the CI

homeassistant/components/vicare/sensor.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft November 13, 2023 13:19
@fb22 fb22 marked this pull request as ready for review November 13, 2023 18:51
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fb22 👍

@edenhaus edenhaus changed the title Add 2 vicare heatpump sensors Add vicare Volumetric flow and Compressor Phase sensors Nov 14, 2023
@edenhaus edenhaus changed the title Add vicare Volumetric flow and Compressor Phase sensors Add Vicare volumetric flow and compressor phase sensors Nov 14, 2023
@edenhaus edenhaus merged commit 96bcc6c into home-assistant:dev Nov 14, 2023
23 checks passed
@fb22 fb22 deleted the fb22-vicare branch November 14, 2023 19:13
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants