Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Z-wave climate sensor override for Heatit Z-TRM6 #103896

Merged
merged 13 commits into from Nov 24, 2023

Conversation

geirra
Copy link
Contributor

@geirra geirra commented Nov 12, 2023

Proposed change

This PR adds support for the z-trm6 z-wave thermostat.
The thermostat supports multiple operation modes and as such it supports 3 temp sensors depending on the config, the pr swaps the climate entity to support show the correct sensor.

Type of change

  • New feature (which adds functionality to an existing integration)

Additional information

The code is done in the same style as z-trm3 + 2, but a better approch might be to don't rely on the template names (that could be changed upstream) and rather the integer value of the config param.
See comment here: zwave-js/node-zwave-js#6464 (review)

But this PR is made in the style of the previous code changes.

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@geirra geirra requested a review from a team as a code owner November 12, 2023 23:51
home-assistant[bot]

This comment was marked as outdated.

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant
Copy link

Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration (zwave_js) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zwave_js can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign zwave_js Removes the current integration label and assignees on the pull request, add the integration domain after the command.

home-assistant[bot]

This comment was marked as outdated.

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @geirra

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@geirra geirra marked this pull request as ready for review November 21, 2023 12:25
@home-assistant home-assistant bot dismissed stale reviews from themself November 21, 2023 12:25

Stale

@MartinHjelmare MartinHjelmare marked this pull request as draft November 22, 2023 15:11
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@geirra geirra marked this pull request as ready for review November 22, 2023 17:18
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Side note for future PRs: Please retain the whole PR description template, also the parts that are not applicable, like breaking change section etc. Leave the parts that aren't applicable empty.

@MartinHjelmare MartinHjelmare merged commit d4450c6 into home-assistant:dev Nov 24, 2023
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants