Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ring_doorbell to 0.8.0 and handle new exceptions #103904

Merged
merged 2 commits into from Nov 14, 2023

Conversation

sdb9696
Copy link
Contributor

@sdb9696 sdb9696 commented Nov 13, 2023

Proposed change

As part of #103758 to add reauth support to the ring integration, the ring_doorbell library needs to be updated to 0.8.0 to handle new ring_doorbell exceptions. This PR includes that bump and handles the new exceptions with the same behaviour as before. It also includes new tests for when the exceptions are raised (which were not previously covered.) Ping @allenporter who requested a separate PR for the bump and exception handling mechanics.

The changelog for ring_doorbell is here

Files changed: tchellomello/python-ring-doorbell@0.7.3...0.8.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@sdb9696 sdb9696 mentioned this pull request Nov 13, 2023
20 tasks
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Nov 13, 2023
Copy link
Contributor

@allenporter allenporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate that the tests were added though I in the future I would suggest this overall PR order:

  • Establish baseline test coverage
  • Swap library and use new exception types (and update tests to use new exception types)
  • Add reauth support

Fine to leave this since I don't want to cause you churn but just wanted to clarify my previous request to pull this into a separate PR

tests/components/ring/test_init.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft November 13, 2023 15:49
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@sdb9696 sdb9696 marked this pull request as ready for review November 13, 2023 19:26
@sdb9696
Copy link
Contributor Author

sdb9696 commented Nov 14, 2023

Hi @allenporter many thanks for the review and approval on this one. Is there anything else I need to do to get this merged? Would you be doing the merge or does it need to be someone else? Thx

@allenporter allenporter merged commit cf6c72f into home-assistant:dev Nov 14, 2023
53 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2023
@sdb9696 sdb9696 deleted the bump_ring_0.8.0 branch April 4, 2024 13:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
by-code-owner cla-signed has-tests integration: ring Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants