New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump ring_doorbell to 0.8.0 and handle new exceptions #103904
Conversation
c5266fa
to
3b7865d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate that the tests were added though I in the future I would suggest this overall PR order:
- Establish baseline test coverage
- Swap library and use new exception types (and update tests to use new exception types)
- Add reauth support
Fine to leave this since I don't want to cause you churn but just wanted to clarify my previous request to pull this into a separate PR
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
274359c
to
a52aa3f
Compare
a52aa3f
to
7c7c1b7
Compare
Hi @allenporter many thanks for the review and approval on this one. Is there anything else I need to do to get this merged? Would you be doing the merge or does it need to be someone else? Thx |
Proposed change
As part of #103758 to add reauth support to the ring integration, the ring_doorbell library needs to be updated to 0.8.0 to handle new ring_doorbell exceptions. This PR includes that bump and handles the new exceptions with the same behaviour as before. It also includes new tests for when the exceptions are raised (which were not previously covered.) Ping @allenporter who requested a separate PR for the bump and exception handling mechanics.
The changelog for ring_doorbell is here
Files changed: tchellomello/python-ring-doorbell@0.7.3...0.8.0
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: