New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add websocket command to capture audio from a device #103936
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey there @balloob, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
balloob
reviewed
Nov 14, 2023
balloob
reviewed
Nov 14, 2023
balloob
reviewed
Nov 14, 2023
balloob
reviewed
Nov 14, 2023
balloob
reviewed
Nov 15, 2023
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
synesthesiam
force-pushed
the
synesthesiam-20231113-device-capture
branch
from
November 15, 2023 20:18
80f89ba
to
90d8948
Compare
balloob
approved these changes
Nov 16, 2023
balloob
reviewed
Nov 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Intended for discussion; tests have not yet been written.
This PR adds a new websocket command:
assist_pipeline/device/capture
that causes all audio sent to HA from a specificdevice_id
to be forwarded to the websocket client. Limitations are in place to prevent abuse of this command:With the
assist_pipeline/device/capture
command, the frontend device page for voice satellites could be extended to include a button to capture audio and play it back. This would make checking audio settings significantly easier than turning on the assist pipeline debug recording feature, which requires restarting HA and is not intended to be left on.Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: