Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove openexchangerates sensor rounding #103972

Merged
merged 1 commit into from Nov 14, 2023
Merged

Conversation

MartinHjelmare
Copy link
Member

@MartinHjelmare MartinHjelmare commented Nov 14, 2023

Breaking change

Remove rounding of the exchange rate.

Exchange rates are generally more sensitive to small changes and some quotes need many decimal numbers to be accurate. The Open Exchange Rates service will provide different number of significant digits for different quotes. You can change the display precision or use a template sensor if you want to customize the rounding of the value.

Proposed change

  • Remove rounding of the exchange rate.
  • Exchange rates are generally more sensitive to small changes and some quotes need many decimal numbers to be accurate. The Open Exchange Rates service will provide different number of significant digits for different quotes. We should just use what they return. The user can change the display precision or use a template sensor if they want to customize rounding.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@joostlek
Copy link
Member

Can't we set the suggested_display_precision to 4 on the sensor to avoid changing the UI?

@MartinHjelmare
Copy link
Member Author

I don't think that's a good idea as I've tried to explain in the PR description. Here's an example how that would look for BTC.

btc

@balloob balloob merged commit 9facdc2 into dev Nov 14, 2023
23 checks passed
@balloob balloob deleted the openexchangerates-no-rounding branch November 14, 2023 18:01
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open Exchange Rate Integration has a 4 decimal limit, which prevents use of various metals/currencies
3 participants