Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix netatmo authentication when using cloud authentication credentials #104021

Merged
merged 9 commits into from Nov 15, 2023

Conversation

deosrc
Copy link
Contributor

@deosrc deosrc commented Nov 15, 2023

Proposed change

Fixes the Netatmo authentication when using cloud authentication credentials. This was broken in the recent external library upgrade as new (unsupported) OAuth scopes were introduced.

Ideally this would be included as a hotfix as it is preventing use of the integration in the current version.

Thanks to @cgtobi for their contributions on this.

There were comments if this should be a static list of scopes rather than filtering out specific scopes (request only required scopes rather than everything), however, to get the fix in and minimise changes, this has been left as a potential future change.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @cgtobi, mind taking a look at this pull request as it has been labeled with an integration (netatmo) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of netatmo can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign netatmo Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@deosrc deosrc marked this pull request as ready for review November 15, 2023 08:59
@jpbede jpbede added this to the 2023.11.3 milestone Nov 15, 2023
Copy link
Contributor

@cgtobi cgtobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @deosrc
LGTM

@balloob balloob merged commit c92945e into home-assistant:dev Nov 15, 2023
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2023
@deosrc deosrc deleted the fix/netatmo-auth branch November 23, 2023 10:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Netatmo integration cannot go trough add process
5 participants