New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CB3 descriptor to ZHA manifest #104071
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Haerteleric
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @dmulcahey, @Adminiuga, @puddly, @TheJulianJES, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
@Haerteleric is there any reason this is still in draft? |
Uh i dunno, how to i change the Tag ? This Kinda my first PR to HA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Haerteleric 👍
../Frenck
@Haerteleric did you also submit a PR for ZHA docs update? next branch if done before 2023.12 release or the current release if done after the 2023.12 release https://github.com/home-assistant/home-assistant.io/blob/next/source/_integrations/zha.markdown https://github.com/home-assistant/home-assistant.io/blob/current/source/_integrations/zha.markdown |
Proposed change
In conjunction with recent modifications to zigpy-deconz. The CB3 usb-descriptor was added to the ZHA manifest.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: