Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CB3 descriptor to ZHA manifest #104071

Merged
merged 3 commits into from Dec 4, 2023
Merged

Add CB3 descriptor to ZHA manifest #104071

merged 3 commits into from Dec 4, 2023

Conversation

Haerteleric
Copy link
Contributor

@Haerteleric Haerteleric commented Nov 16, 2023

Proposed change

In conjunction with recent modifications to zigpy-deconz. The CB3 usb-descriptor was added to the ZHA manifest.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • [x ] The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Haerteleric

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft November 16, 2023 11:19
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant
Copy link

Hey there @dmulcahey, @Adminiuga, @puddly, @TheJulianJES, mind taking a look at this pull request as it has been labeled with an integration (zha) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zha can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign zha Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@MartinHjelmare MartinHjelmare changed the title Added CB3 Discriptor to ZHA Manifest Add CB3 Discriptor to ZHA Manifest Nov 16, 2023
@MartinHjelmare MartinHjelmare changed the title Add CB3 Discriptor to ZHA Manifest Add CB3 descriptor to ZHA manifest Nov 16, 2023
@elupus
Copy link
Contributor

elupus commented Dec 3, 2023

@Haerteleric is there any reason this is still in draft?

@puddly puddly added this to the 2023.12.0 milestone Dec 3, 2023
@Haerteleric
Copy link
Contributor Author

@Haerteleric is there any reason this is still in draft?

Uh i dunno, how to i change the Tag ? This Kinda my first PR to HA

@elupus elupus marked this pull request as ready for review December 4, 2023 08:15
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Haerteleric 👍

../Frenck

@frenck frenck merged commit 557e933 into home-assistant:dev Dec 4, 2023
23 checks passed
frenck pushed a commit that referenced this pull request Dec 4, 2023
@Hedda
Copy link
Contributor

Hedda commented Dec 4, 2023

If user exposed functionality or configuration variables are added/changed:

@Haerteleric did you also submit a PR for ZHA docs update?

next branch if done before 2023.12 release or the current release if done after the 2023.12 release

https://github.com/home-assistant/home-assistant.io/blob/next/source/_integrations/zha.markdown

https://github.com/home-assistant/home-assistant.io/blob/current/source/_integrations/zha.markdown

@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
@Haerteleric Haerteleric deleted the ConBeeIII2zha branch December 6, 2023 12:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants