Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Netatmo temperature services #104124

Merged

Conversation

deosrc
Copy link
Contributor

@deosrc deosrc commented Nov 17, 2023

Proposed change

Add Netatmo services for advanced control of room temperature. Allows setting temperature for a given duration, and clearing manually set temperatures to revert to the currently selected schedule.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @cgtobi, mind taking a look at this pull request as it has been labeled with an integration (netatmo) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of netatmo can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign netatmo Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@deosrc deosrc marked this pull request as ready for review November 17, 2023 14:33
Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass.
Thinking I will have the same comments here as in the previous PR for presets so good if you take a look there.

homeassistant/components/netatmo/climate.py Outdated Show resolved Hide resolved
homeassistant/components/netatmo/services.yaml Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft November 18, 2023 22:53
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@deosrc deosrc marked this pull request as ready for review November 18, 2023 23:32
Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have a clear distinction between the services so to do that we should set this new service as we did with preset e.g. name it with end_datetime and make the field required.

When a user wants to just set a temperature he should use climate.set_temperature. When to set with an end datetime use netatmo.set_temperature_with_end_datetime.

Did not make changes for the tests, those obviously also needs to be changed with this.

homeassistant/components/netatmo/climate.py Outdated Show resolved Hide resolved
homeassistant/components/netatmo/climate.py Outdated Show resolved Hide resolved
homeassistant/components/netatmo/climate.py Outdated Show resolved Hide resolved
homeassistant/components/netatmo/climate.py Outdated Show resolved Hide resolved
homeassistant/components/netatmo/climate.py Outdated Show resolved Hide resolved
homeassistant/components/netatmo/const.py Outdated Show resolved Hide resolved
homeassistant/components/netatmo/services.yaml Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft November 18, 2023 23:40
@deosrc
Copy link
Contributor Author

deosrc commented Nov 19, 2023

Ok I've implemented the naming changes as requested.

I also realised my use case (and I expect many other automation use cases) would require the use of jinja to determine the end date & time. It seemed to make sense to have a service to handle time period as well so I've added that.

@deosrc deosrc marked this pull request as ready for review November 19, 2023 16:16
@home-assistant home-assistant bot marked this pull request as draft November 20, 2023 10:55
@deosrc deosrc marked this pull request as ready for review November 20, 2023 14:26
Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't notice before but last bit and then this should be good to go 👍

homeassistant/components/netatmo/strings.json Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft November 22, 2023 19:13
@deosrc deosrc marked this pull request as ready for review November 22, 2023 22:34
Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @deosrc 👍

@gjohansson-ST gjohansson-ST merged commit 5623834 into home-assistant:dev Nov 23, 2023
23 checks passed
@deosrc deosrc deleted the feature/netatmo-set-temperature-services branch November 23, 2023 10:23
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants