New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Netatmo temperature services #104124
Add Netatmo temperature services #104124
Conversation
…mperature-services
…mperature-services
Hey there @cgtobi, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass.
Thinking I will have the same comments here as in the previous PR for presets so good if you take a look there.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have a clear distinction between the services so to do that we should set this new service as we did with preset e.g. name it with end_datetime and make the field required.
When a user wants to just set a temperature he should use climate.set_temperature
. When to set with an end datetime use netatmo.set_temperature_with_end_datetime
.
Did not make changes for the tests, those obviously also needs to be changed with this.
Co-authored-by: G Johansson <goran.johansson@shiftit.se>
Ok I've implemented the naming changes as requested. I also realised my use case (and I expect many other automation use cases) would require the use of jinja to determine the end date & time. It seemed to make sense to have a service to handle time period as well so I've added that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't notice before but last bit and then this should be good to go 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @deosrc 👍
Proposed change
Add Netatmo services for advanced control of room temperature. Allows setting temperature for a given duration, and clearing manually set temperatures to revert to the currently selected schedule.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: