Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small speed up to constructing Bluetooth service_uuids #104193

Merged
merged 1 commit into from Nov 19, 2023
Merged

Small speed up to constructing Bluetooth service_uuids #104193

merged 1 commit into from Nov 19, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 19, 2023

Proposed change

Screenshot 2023-11-18 at 10 51 07 PM

benchmark shows its better to unpack than to create another list and convert it to a set and than convert it to a list which makes sense since it avoids creating one list

Time for add: 0.6585384160280228
Time for unpack: 0.597992334049195

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Contributor

@elupus elupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I assume its a bleak choice to have it a list rather than set all the time.

@bdraco
Copy link
Member Author

bdraco commented Nov 19, 2023

Looks good.

Thanks

I assume its a bleak choice to have it a list rather than set all the time.

Yes, its a bleak decision that we have to live with.

@bdraco bdraco merged commit e7cec9b into dev Nov 19, 2023
53 checks passed
@bdraco bdraco deleted the unpack_ble branch November 19, 2023 14:14
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants