New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add domain key config validation #104242
Merged
Merged
Add domain key config validation #104242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenck
approved these changes
Nov 20, 2023
emontnemery
commented
Nov 20, 2023
frenck
reviewed
Nov 21, 2023
I'll rework the PR to use the same method everywhere, and it seems the opinion is python is better than regex in this case |
emontnemery
force-pushed
the
extract_domain_configs_remove_regex
branch
from
December 4, 2023 12:09
5fb3f67
to
f5e5fc3
Compare
MartinHjelmare
changed the title
Drop use of regex in helpers.extract_domain_configs
Add domain key config validation
Dec 5, 2023
MartinHjelmare
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Maybe update the PR description a bit. I changed the PR title.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Use a common validator,
cv.domain_key
to validate a top level config key with an optional label and return the domain.A domain is separated from a label by one or more spaces, empty labels are not allowed.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: