Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reolink ptz service to specify move speed #104350

Merged
merged 4 commits into from Nov 24, 2023

Conversation

starkillerOG
Copy link
Contributor

@starkillerOG starkillerOG commented Nov 22, 2023

Breaking change

Proposed change

Add custom service to Reolink to allow PTZ movements of the camera with a custom move speed.

Note: I don't really like the way in which I filter the entities that support the service:
SUPPORT_PTZ_SPEED = CameraEntityFeature.STREAM

      supported_features:
        - camera.CameraEntityFeature.STREAM

I would be really happy if someone could come up with a cleaner solution to filter the entities based on the camera features: self._host.api.supported(channel, "ptz_speed")

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @starkillerOG 👍

../Frenck

@frenck frenck merged commit e9dd158 into home-assistant:dev Nov 24, 2023
23 checks passed
@starkillerOG starkillerOG deleted the reolink_ptz_speed branch November 24, 2023 11:09
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants