Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagnostics platform to Reolink #104378

Merged
merged 5 commits into from Nov 23, 2023

Conversation

starkillerOG
Copy link
Contributor

@starkillerOG starkillerOG commented Nov 22, 2023

Breaking change

Proposed change

Add diagnostics platform to Reolink

TO DO: This needs a version bump of reolink-aio to 0.8.1: #104382

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@starkillerOG starkillerOG marked this pull request as ready for review November 22, 2023 20:35
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Nov 23, 2023
Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Thnx @starkillerOG 👍

@joostlek joostlek changed the title Reolink add diagnostics platform Add diagnostics platform to Reolink Nov 23, 2023
@joostlek joostlek merged commit 6b138a2 into home-assistant:dev Nov 23, 2023
23 checks passed
@starkillerOG starkillerOG deleted the reolink_diagnostic branch November 23, 2023 12:41
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants