Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework some UniFi unique IDs #104390

Merged
merged 3 commits into from Nov 24, 2023
Merged

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Nov 22, 2023

Breaking change

Proposed change

First commit rework the unique Id of client tracker from using uses suffix to prefix.
Test coverage is part of the test_device_tracker.py-test_restoring_client

Second commit rework unique Id of poe and outlet switches from using midfix to prefix.
New test written.

After this all unique ids are either obj_id or prefix-obj_id

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@Kane610 Kane610 changed the title Rework UniFi client tracker unique ID Rework some UniFi unique IDs Nov 22, 2023
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Nov 23, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Kane610 👍

../Frenck

@frenck frenck merged commit 6271fe3 into home-assistant:dev Nov 24, 2023
23 checks passed
@Kane610 Kane610 deleted the unifi-rework_unique_ids branch November 24, 2023 17:42
@Kane610
Copy link
Member Author

Kane610 commented Nov 24, 2023

Thanks @frenck 🎉

@disforw
Copy link
Contributor

disforw commented Nov 24, 2023

Should this be marked ‘breaking’ if you’re changing the unique id?

@frenck
Copy link
Member

frenck commented Nov 24, 2023

Should this be marked ‘breaking’ if you’re changing the unique id?

It has a migration for those, so it isn't breaking.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
by-code-owner cla-signed code-quality integration: unifi Quality Scale: platinum small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants