Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aioesphomeapi to 19.0.1 #104527

Merged
merged 1 commit into from Nov 25, 2023
Merged

Bump aioesphomeapi to 19.0.1 #104527

merged 1 commit into from Nov 25, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 25, 2023

Proposed change

changelog: esphome/aioesphomeapi@v19.0.0...v19.0.1

speeds up processing plaintext frames and deletes a large chunk of the frame text helper code since I came up with a better way to do it

before: Processed 3000000 bluetooth messages took 1.0178361660218798 seconds
after: Processed 3000000 bluetooth messages took 0.5595999580109492 seconds

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

speeds up processing plaintext frames

python3 bench/raw_ble_plain_text.py

before
```
Processed 3000000 bluetooth messages took 1.0178361660218798 seconds
```
after
```
Processed 3000000 bluetooth messages took 0.5595999580109492 seconds
```
@home-assistant
Copy link

Hey there @OttoWinter, @jesserockz, @kbx81, mind taking a look at this pull request as it has been labeled with an integration (esphome) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of esphome can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign esphome Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point one would imagine you'd hit a limit on how fast it can be..

@bdraco
Copy link
Member Author

bdraco commented Nov 25, 2023

Its still pretty high up on the profile so there is more to do, but I haven't come up with a better way yet.

I'm running the benchmarks on my m2 mac so the numbers tend to be an order of magnitude worse on the yellow

@bdraco
Copy link
Member Author

bdraco commented Nov 25, 2023

thanks

@bdraco
Copy link
Member Author

bdraco commented Nov 25, 2023

I didn't intend to do two releases today but I came back from walking the pup and realized I could get the plaintext frame helper down to ~100 lines so it seemed worth doing since it got rid of tons of the complexity

@bdraco bdraco merged commit 498bea0 into dev Nov 25, 2023
70 checks passed
@bdraco bdraco deleted the aioesphomeapi1901 branch November 25, 2023 21:46
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants