New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump aioesphomeapi to 19.0.1 #104527
Bump aioesphomeapi to 19.0.1 #104527
Conversation
speeds up processing plaintext frames python3 bench/raw_ble_plain_text.py before ``` Processed 3000000 bluetooth messages took 1.0178361660218798 seconds ``` after ``` Processed 3000000 bluetooth messages took 0.5595999580109492 seconds ```
Hey there @OttoWinter, @jesserockz, @kbx81, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At some point one would imagine you'd hit a limit on how fast it can be..
Its still pretty high up on the profile so there is more to do, but I haven't come up with a better way yet. I'm running the benchmarks on my m2 mac so the numbers tend to be an order of magnitude worse on the yellow |
thanks |
I didn't intend to do two releases today but I came back from walking the pup and realized I could get the plaintext frame helper down to ~100 lines so it seemed worth doing since it got rid of tons of the complexity |
Proposed change
changelog: esphome/aioesphomeapi@v19.0.0...v19.0.1
speeds up processing plaintext frames and deletes a large chunk of the frame text helper code since I came up with a better way to do it
before: Processed 3000000 bluetooth messages took 1.0178361660218798 seconds
after: Processed 3000000 bluetooth messages took 0.5595999580109492 seconds
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: