Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ServiceValidationError for invalid fan preset_mode and move check to fan entity component #104560

Merged
merged 23 commits into from
Nov 29, 2023
Merged

Use ServiceValidationError for invalid fan preset_mode and move check to fan entity component #104560

merged 23 commits into from
Nov 29, 2023

Commits on Nov 26, 2023

  1. Use ServiceValidationError for fan preset_mode

    @jbouwh
    jbouwh committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    e754ef4 View commit details
    Browse the repository at this point in the history

  2. Use _valid_preset_mode_or_raise to raise

    @jbouwh
    jbouwh committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    4ede0af View commit details
    Browse the repository at this point in the history

  3. Move preset_mode validation to entity component

    @jbouwh
    jbouwh committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    b5f4332 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. Fix bond fan and comments

    @jbouwh
    jbouwh committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    c92e5ca View commit details
    Browse the repository at this point in the history

  2. Fixes baf, fjaraskupan and template

    @jbouwh
    jbouwh committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    b03a4f6 View commit details
    Browse the repository at this point in the history

  3. More integration adjustments

    @jbouwh
    jbouwh committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    1bc45e2 View commit details
    Browse the repository at this point in the history

  4. Add custom components mock and test code

    @jbouwh
    jbouwh committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    edd1785 View commit details
    Browse the repository at this point in the history

  5. Make NotValidPresetModeError subclass

    @jbouwh
    jbouwh committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    aeff78f View commit details
    Browse the repository at this point in the history

  6. Update homeassistant/components/fan/strings.json 

    Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
    @jbouwh @MartinHjelmare
    jbouwh and MartinHjelmare committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    b4f58b1 View commit details
    Browse the repository at this point in the history

  7. Keep bond has_action validation

    @jbouwh
    jbouwh committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    21c1f53 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'dev' into jbouwh-demo-fan-preset_mode-exc

    @jbouwh
    jbouwh committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    7417f37 View commit details
    Browse the repository at this point in the history

  9. Move demo test asserts outside context block

    @jbouwh
    jbouwh committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    c084448 View commit details
    Browse the repository at this point in the history

  10. Follow up comment

    @jbouwh
    jbouwh committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    b1c696c View commit details
    Browse the repository at this point in the history

  11. Update homeassistant/components/fan/strings.json 

    Co-authored-by: G Johansson <goran.johansson@shiftit.se>
    @jbouwh @gjohansson-ST
    jbouwh and gjohansson-ST committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    5999f16 View commit details
    Browse the repository at this point in the history

  12. Fix demo tests

    @jbouwh
    jbouwh committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    78ea4c1 View commit details
    Browse the repository at this point in the history

  13. Remove pylint disable

    @jbouwh
    jbouwh committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    2e2d5ad View commit details
    Browse the repository at this point in the history

  14. Remove unreachable code

    @jbouwh
    jbouwh committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    65f5c15 View commit details
    Browse the repository at this point in the history

  15. Update homeassistant/components/fan/__init__.py 

    Co-authored-by: G Johansson <goran.johansson@shiftit.se>
    @jbouwh @gjohansson-ST
    jbouwh and gjohansson-ST committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    6335fd8 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. Use NotValidPresetModeError, Final methods

    @jbouwh
    jbouwh committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    b97764e View commit details
    Browse the repository at this point in the history

  2. Address comments

    @jbouwh
    jbouwh committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    6e705b3 View commit details
    Browse the repository at this point in the history

  3. Correct docst

    @jbouwh
    jbouwh committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    b96e284 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. Follow up comments

    @jbouwh
    jbouwh committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    01af2ff View commit details
    Browse the repository at this point in the history

  2. Update homeassistant/components/fan/__init__.py 

    Co-authored-by: Erik Montnemery <erik@montnemery.com>
    @jbouwh @emontnemery
    jbouwh and emontnemery committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    aad8a86 View commit details
    Browse the repository at this point in the history