Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aioesphomeapi to 19.1.4 #104629

Merged
merged 1 commit into from Nov 28, 2023
Merged

Bump aioesphomeapi to 19.1.4 #104629

merged 1 commit into from Nov 28, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 28, 2023

needs https://github.com/esphome/aioesphomeapi/actions/runs/7014791763

Proposed change

  • Rearranging and removal of duplicate code now that it was safer to do since we have 100% line coverage
  • Gets rid of the confusing internal perform_handshake function since after previous refactoring all it did was wait on a future and did not actually do the handshake anymore. This allows the frame helper to be completely free of anything that awaits which should significantly reduce the chance we accidentally introduce races in the future.
  • Connecting the frame helper and doing the handshake is just a tiny bit faster (might safe a nanosecond or two) but thats more of a side effect

changelog: esphome/aioesphomeapi@v19.1.3...v19.1.4

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

- Rearranging and removal of duplicate code
  now that it was safer to do since we have
  100% line coverage

changelog: esphome/aioesphomeapi@v19.1.3...v19.1.4
@home-assistant
Copy link

Hey there @OttoWinter, @jesserockz, @kbx81, mind taking a look at this pull request as it has been labeled with an integration (esphome) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of esphome can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign esphome Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@bdraco bdraco closed this Nov 28, 2023
@bdraco bdraco reopened this Nov 28, 2023
@bdraco bdraco marked this pull request as ready for review November 28, 2023 06:17
@bdraco bdraco closed this Nov 28, 2023
@bdraco bdraco reopened this Nov 28, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bdraco 👍

../Frenck

@frenck frenck merged commit e048ad5 into dev Nov 28, 2023
97 of 104 checks passed
@frenck frenck deleted the aioesphomeapi1914 branch November 28, 2023 07:20
@bdraco
Copy link
Member Author

bdraco commented Nov 28, 2023

Thanks!

Can probably delete another 40-50 lines in the library today and that should wrap up things for 2023.12.x

@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants