New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump aioesphomeapi to 19.1.7 #104644
Merged
Merged
Bump aioesphomeapi to 19.1.7 #104644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog: esphome/aioesphomeapi@v19.1.4...v19.1.5 - Removes the need to watch for BLE connection drops with a seperate future as the library now raises BluetoothConnectionDroppedError when the connection drops during a BLE operation
home-assistant
bot
added
cla-signed
dependency
integration: esphome
small-pr
PRs with less than 30 lines.
labels
Nov 28, 2023
Hey there @OttoWinter, @jesserockz, @kbx81, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
bdraco
commented
Nov 28, 2023
MartinHjelmare
approved these changes
Nov 28, 2023
Thanks. I'll get rid of the workarounds I mentioned above if I have time to add more coverage to the lib to verify removing them is safe |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
by-code-owner
cla-signed
dependency
integration: esphome
Quality Scale: No score
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs https://github.com/esphome/aioesphomeapi/actions/runs/7020666677Proposed change
changelog: esphome/aioesphomeapi@v19.1.4...v19.1.7
BluetoothConnectionDroppedError
when the connection drops during a BLE operation which allows us to delete all thedisconnected_futures
codeThis gets rid of a lot of complexity and the bulk of the overhead is now the actual asyncio (socket) write and the timeout
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: