New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump aioairq to 0.3.1 #104659
Bump aioairq to 0.3.1 #104659
Conversation
`const.TARGET_ROUTE: Final = "average"` is obsolete as the new API implies it. The new call also drops the uncertainties from the data so the respective line can be removed from `AirQCoordinator._async_update_data`
Hey there @dl2080, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are failing, can you take a look?
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
New version of aioairq broke the old package structure
fixed, my apologies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Sibgatulin 👍
../Frenck
Proposed change
Bump aioairq version to 0.3.1 (diff) which allows clipping of spuriously negative sensor values. This version offers a slightly different API, which is now used in
AirQCoordinator._async_update_data
.This PR is split from another draft, following @joostlek's proposition.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: