New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Philips TV none recordings_list #104665
Fix Philips TV none recordings_list #104665
Conversation
Hey there @elupus, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I simplified the checks, need to go into beta so should be as simple as possible
Correct for missing recordings list in api client. --------- Co-authored-by: Joakim Plate <elupus@ecce.se>
Thank you for the commit, I had no time yesterday. |
Proposed change
The newly added added recording_list functionality for philips_js 01c49ba has a bug, which did not occured while developing.
It was missed to add a scenario in which the TV has the right API and has the needed functionality.
Neverless for some TV the recordings_list is not available if the TV is off or in StandBy.
This PR adds a check prior accessing the data to prevent an error.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: