Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Philips TV none recordings_list #104665

Merged
merged 9 commits into from Nov 29, 2023

Conversation

Floyer007
Copy link
Contributor

Proposed change

The newly added added recording_list functionality for philips_js 01c49ba has a bug, which did not occured while developing.
It was missed to add a scenario in which the TV has the right API and has the needed functionality.
Neverless for some TV the recordings_list is not available if the TV is off or in StandBy.

This PR adds a check prior accessing the data to prevent an error.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @elupus, mind taking a look at this pull request as it has been labeled with an integration (philips_js) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of philips_js can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign philips_js Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@MartinHjelmare MartinHjelmare changed the title Philips TV none recordings_list bugfix Fix Philips TV none recordings_list Nov 28, 2023
Copy link
Contributor

@elupus elupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I simplified the checks, need to go into beta so should be as simple as possible

@elupus elupus added this to the 2023.12.0 milestone Nov 29, 2023
@elupus elupus merged commit 7638b9b into home-assistant:dev Nov 29, 2023
23 checks passed
frenck pushed a commit that referenced this pull request Nov 30, 2023
Correct for missing recordings list in api client.
---------

Co-authored-by: Joakim Plate <elupus@ecce.se>
@Floyer007
Copy link
Contributor Author

I simplified the checks, need to go into beta so should be as simple as possible

Thank you for the commit, I had no time yesterday.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2023
@Floyer007 Floyer007 deleted the philips_js-no_list-bugfix branch December 18, 2023 23:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with new binary sensor for recodings in philips_js integration
3 participants