Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update stookwijzer api to atlas leefomgeving (#103323)" #104705

Merged

Conversation

frenck
Copy link
Member

@frenck frenck commented Nov 29, 2023

Proposed change

This reverts commit 9dc5d4a of PR #103323.

The dependencies used in the bump that is in that PR, are not buildable for distribution. See also #104699, which tried to address it, but was reverted in #104704.

As this is currently a release blocker for us (failed builds), I've decided to revert this change for now.

/CC @fwestenberg @joostlek

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @fwestenberg, mind taking a look at this pull request as it has been labeled with an integration (stookwijzer) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of stookwijzer can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign stookwijzer Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@joostlek
Copy link
Member

How could I have recognised this?

@frenck
Copy link
Member Author

frenck commented Nov 29, 2023

How could I have recognised this?

You couldn't have. No-one to blame here :)

@joostlek
Copy link
Member

What steps can we now take to bring this change in?

@frenck
Copy link
Member Author

frenck commented Nov 29, 2023

We need to see if there is something different than pyproj we can use

@frenck frenck marked this pull request as draft November 29, 2023 11:37
@frenck
Copy link
Member Author

frenck commented Nov 29, 2023

@ludeeus pointed out an error in my attempt to fix Wheels CI, going to give it another shot.

@frenck
Copy link
Member Author

frenck commented Nov 29, 2023

Got it to build. However, a new subdep is also Shapely (from pyreproj), which is impossible to build for armhf. We have no choice but revering this PR

image

@frenck frenck marked this pull request as ready for review November 29, 2023 14:18
@frenck frenck merged commit 8f2e69f into dev Nov 29, 2023
53 checks passed
@frenck frenck deleted the revert-103323-Update-Stookwijzer-api-to-Atlas-Leefomgeving branch November 29, 2023 14:18
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants