Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid db hit and executor job for impossible history queries #104724

Merged
merged 1 commit into from Nov 29, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 29, 2023

Proposed change

The frontend is much more likely to make an impossible history query now that users can go back in time and see stats on the graphs from the UI. home-assistant/frontend#18213

We already have coverage for via test_history_stream_before_history_starts and test_fetch_period_api_before_history_started, and this PR only makes the check happen sooner to avoid the executor job (and likely the db hit if it was not already suppressed)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (history) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of history can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign history Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@bdraco bdraco marked this pull request as ready for review November 29, 2023 14:42
@bdraco bdraco requested a review from a team as a code owner November 29, 2023 14:42
@bdraco
Copy link
Member Author

bdraco commented Nov 29, 2023

Verified history query is never made now if I look at August dates which is before history is recorded

2023-11-29 08:44:16.071 INFO (DbWorker_1) [sqlalchemy.engine.Engine] SELECT statistics.metadata_id, statistics.start_ts, statistics.mean 
FROM statistics 
WHERE statistics.start_ts >= ? AND statistics.start_ts < ? AND statistics.metadata_id IN (?) ORDER BY statistics.metadata_id, statistics.start_ts
2023-11-29 08:44:16.071 INFO (DbWorker_1) [sqlalchemy.engine.Engine] [cached since 164.1s ago] (1690866000.0, 1693544399.0, 52)
2023-11-29 08:44:16.074 INFO (DbWorker_0) [sqlalchemy.engine.Engine] BEGIN (implicit)
2023-11-29 08:44:16.074 INFO (DbWorker_0) [sqlalchemy.engine.Engine] SELECT states.metadata_id, states.state, states.last_updated_ts 
FROM states 
WHERE (states.last_changed_ts = states.last_updated_ts OR states.last_changed_ts IS NULL) AND states.metadata_id IN (?) AND states.last_updated_ts > ? AND states.last_updated_ts < ? ORDER BY states.metadata_id, states.last_updated_ts
2023-11-29 08:44:16.074 INFO (DbWorker_0) [sqlalchemy.engine.Engine] [cached since 168.4s ago] (80, 1690866000.0, 1693544399.0)
2023-11-29 08:44:16.075 INFO (DbWorker_0) [sqlalchemy.engine.Engine] ROLLBACK
2023-11-29 08:44:16.081 INFO (DbWorker_1) [sqlalchemy.engine.Engine] ROLLBACK
2023-11-29 08:44:16.904 INFO (Recorder) [sqlalchemy.engine.Engine] BEGIN (implicit)

@bdraco
Copy link
Member Author

bdraco commented Nov 29, 2023

line is actually hit, codecov is showing unrelated changes here

@bdraco
Copy link
Member Author

bdraco commented Nov 29, 2023

Thanks

@bdraco bdraco merged commit 50f2c41 into dev Nov 29, 2023
23 checks passed
@bdraco bdraco deleted the history_impossible branch November 29, 2023 18:20
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants