Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reolink schedule update after firmware update #104867

Merged
merged 3 commits into from Dec 1, 2023
Merged

Reolink schedule update after firmware update #104867

merged 3 commits into from Dec 1, 2023

Conversation

starkillerOG
Copy link
Contributor

Breaking change

Proposed change

2 minutes after installing a new Reolink firmware, schedual a update of the data coordinator.
Normal update intervall is 12 hours, this confuses users because once a new firmware is discovered it takes 12 hours before it would disapear again after the user updated the firmware.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

jbouwh
jbouwh approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Thnx @starkillerOG 👍

@starkillerOG starkillerOG added this to the 2023.12.0 milestone Dec 1, 2023
@starkillerOG starkillerOG merged commit 742e2db into home-assistant:dev Dec 1, 2023
23 checks passed
@starkillerOG starkillerOG deleted the reolink_update_schedual branch December 1, 2023 11:26
@starkillerOG starkillerOG changed the title Reolink schedual update after firmware update Reolink schedule update after firmware update Dec 1, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jbouwh jbouwh jbouwh approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed integration: reolink Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2023.12.0
Development

Successfully merging this pull request may close these issues.

Reolink Camera after Update
3 participants
@starkillerOG @jbouwh @frenck