Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incompatible 'measurement' state and 'volume' device class warnings in Overkiz #104896

Merged
merged 1 commit into from Dec 4, 2023

Conversation

pdecat
Copy link
Contributor

@pdecat pdecat commented Dec 2, 2023

This PR includes fixes to eliminate warning such as:

2023-12-02 09:20:39.475 INFO (MainThread) [homeassistant.components.water_heater] Setting up water_heater.overkiz
2023-12-02 09:20:39.482 WARNING (MainThread) [homeassistant.components.sensor] Entity sensor.dhwp_actuator_water_volume_estimation_at_40_degc (<class 'homeassistant.components.overkiz.sensor.OverkizStateSensor'>) is using state class 'measurement' which is impossible considering device class ('volume') it is using; expected None or one of 'total', 'total_increasing'; Please update your configuration if your entity is manually configured, otherwise create a bug report at https://github.com/home-assistant/core/issues?q=is%3Aopen+is%3Aissue+label%3A%22integration%3A+overkiz%22
2023-12-02 09:20:39.483 WARNING (MainThread) [homeassistant.components.sensor] Entity sensor.dhwp_actuator_water_consumption (<class 'homeassistant.components.overkiz.sensor.OverkizStateSensor'>) is using state class 'measurement' which is impossible considering device class ('volume') it is using; expected None or one of 'total', 'total_increasing'; Please update your configuration if your entity is manually configured, otherwise create a bug report at https://github.com/home-assistant/core/issues?q=is%3Aopen+is%3Aissue+label%3A%22integration%3A+overkiz%22

Such changes were already mentioned in several PRs, but never made it into dev:

…evice class warnings with CozyTouch water heaters
@home-assistant
Copy link

home-assistant bot commented Dec 2, 2023

Hey there @iMicknl, @vlebourl, @tetienne, @nyroDev, mind taking a look at this pull request as it has been labeled with an integration (overkiz) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of overkiz can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign overkiz Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

@tetienne tetienne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx 🙏 and indeed I never merged my PR

Copy link
Contributor

@iMicknl iMicknl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @pdecat.

This change was long due indeed..

@iMicknl iMicknl changed the title fix(overkiz): resolve incompatible 'measurement' state and 'volume' device class warnings with CozyTouch water heaters Fix incompatible 'measurement' state and 'volume' device class warnings in Overkiz Dec 2, 2023
@frenck frenck added this to the 2023.12.0 milestone Dec 4, 2023
@frenck frenck merged commit 8e42105 into home-assistant:dev Dec 4, 2023
23 checks passed
@pdecat pdecat deleted the fix/overkiz_water_heater branch December 4, 2023 12:51
frenck pushed a commit that referenced this pull request Dec 4, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants