Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make UniFi WiFi clients numerical #105032

Merged
merged 1 commit into from Dec 5, 2023
Merged

Make UniFi WiFi clients numerical #105032

merged 1 commit into from Dec 5, 2023

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Dec 4, 2023

Breaking change

Proposed change

"These values are treated as discrete values. By changing them to numerical, it would be possible to display a line chart"

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@Kane610 Kane610 added this to the 2023.12.0 milestone Dec 4, 2023
tofuSCHNITZEL
tofuSCHNITZEL approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@tofuSCHNITZEL tofuSCHNITZEL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

edenhaus
edenhaus approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Kane610 👍

@edenhaus edenhaus merged commit e80ee09 into home-assistant:dev Dec 5, 2023
23 checks passed
frenck pushed a commit that referenced this pull request Dec 5, 2023
@Kane610 @frenck
Make UniFi WiFi clients numerical (#105032)
7cb3831
@Kane610 Kane610 deleted the unifi-wlan_clients_make_numerical branch December 5, 2023 20:40
@Kane610
Copy link
Member Author

Kane610 commented Dec 5, 2023

Thanks @edenhaus 🎉

@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tofuSCHNITZEL tofuSCHNITZEL tofuSCHNITZEL approved these changes

@edenhaus edenhaus edenhaus approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed integration: unifi Quality Scale: platinum small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2023.12.0
Development

Successfully merging this pull request may close these issues.

Unifi network integration: Wifi client sensor reporting discrete values
4 participants
@Kane610 @tofuSCHNITZEL @edenhaus @frenck