Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump yolink-api to 0.3.4 #105124

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Conversation

matrixd2
Copy link
Contributor

@matrixd2 matrixd2 commented Dec 6, 2023

Proposed change

Bump yolink-api to version 0.3.4

YoSmart-Inc/yolink-api@v0.3.1...v0.3.4

  • Compatible with pydantic v2
  • Fix unexcept exception happens when flexfob report state at startup, Cause mqtt client to reconnect

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@joostlek
Copy link
Member

joostlek commented Dec 6, 2023

I'm a bit confused, why is 0.3.3 tagged as 0.3.2.beta2? An why does the 0.3.3 tag lead to an older version?

@joostlek joostlek mentioned this pull request Dec 6, 2023
66 tasks
@matrixd2
Copy link
Contributor Author

matrixd2 commented Dec 6, 2023

I'm a bit confused, why is 0.3.3 tagged as 0.3.2.beta2? An why does the 0.3.3 tag lead to an older version?

@joostlek The description has been updated, its because the v0.3.3 branch was previously created for other features.

@joostlek
Copy link
Member

joostlek commented Dec 6, 2023

I would feel a lot more comfortable if the library could be bumped to 0.3.4 with right tags and versioning, WDYT?

@matrixd2
Copy link
Contributor Author

matrixd2 commented Dec 6, 2023

I would feel a lot more comfortable if the library could be bumped to 0.3.4 with right tags and versioning, WDYT?

Thanks, I will clean up my branchs and tags

@matrixd2 matrixd2 changed the title Bump yolink-api to 0.3.3 Bump yolink-api to 0.3.4 Dec 7, 2023
@joostlek joostlek added this to the 2023.12.1 milestone Dec 7, 2023
@joostlek joostlek merged commit 4666d7e into home-assistant:dev Dec 7, 2023
52 of 53 checks passed
@joostlek
Copy link
Member

joostlek commented Dec 7, 2023

Thanks for bumping. I wanted to recheck the dependency but haven't found the time yet, but this also solves it.

Also thanks for helping with the Pydantic migration ❤️

@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants