Use freezegun in cert_expiry tests #105125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
code-quality
has-tests
integration: cert_expiry
small-pr
|
Hey there @jjlawren, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
joostlek
reviewed
Dec 6, 2023
| @@ -15,8 +17,8 @@ | |||
| from tests.common import MockConfigEntry, async_fire_time_changed | |||
|
|
|||
|
|
|||
| @patch("homeassistant.util.dt.utcnow", return_value=static_datetime()) | |||
| async def test_async_setup_entry(mock_now, hass: HomeAssistant) -> None: | |||
There was a problem hiding this comment.
This is what the patch decorator injects
There was a problem hiding this comment.
It isn't used anywhere in the function
There was a problem hiding this comment.
aah, I thought it might be a fixture. not sure where it would be used, but if this was a local one it could be removed
There was a problem hiding this comment.
You might be able to use the freezer: FrozenDateTimeFactory fixture here
bdraco
approved these changes
Dec 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Make use of freezegun instead of patching
utcnowdirectly in cert_expiry testsType of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: