Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase ping update interval to 30 seconds #105199

Merged
merged 1 commit into from Dec 7, 2023

Conversation

jpbede
Copy link
Member

@jpbede jpbede commented Dec 7, 2023

Proposed change

After some discussion with the core dev team, 15 seconds are too fast, especially with external services.
Thus set the interval to 30 seconds, which is seems to be a good compromise between fast and not overloading things

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jpbede 👍

../Frenck

@frenck frenck merged commit 0728106 into home-assistant:dev Dec 7, 2023
23 checks passed
@jpbede jpbede added this to the 2023.12.1 milestone Dec 7, 2023
@jpbede jpbede deleted the ping-interval branch December 7, 2023 09:12
@danmrossi
Copy link

Is it possible to re add like in yaml the ability to set our own interval?

@danmrossi
Copy link

As I have various automations and stuff that now don’t work properly because I cannot specify my own ping interval.

Can we please, please reinstate the ability to be able to SET OUR OWN ping interval please? Even if it’s a global option only that is perfectly fine.

@jpbede i am so very thankful for your assistance with my issue that you helped me get past and please look at this as constructive criticism as I am all for change and moving things away from YAML code etc BUT NOT when it gets decided for us what functionalities and options we lose the ability to have or to modify as some of us use the Home Assistant ecosystem for other projects besides making a smart home :)

@home-assistant home-assistant locked as resolved and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants