Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration for old HomeWizard sensors #105251

Merged
merged 5 commits into from
Dec 8, 2023

Conversation

DCSBL
Copy link
Contributor

@DCSBL DCSBL commented Dec 7, 2023

Proposed change

This migrates total_power_*_t1_kwh to total_power_*_kwh, when total_power_*_kwh does not exists. This solves an issue where users can't access long-term storage data for the HomeWizard Energy Socket.

The problem;

  • The Energy Socket did not have a total_power_*_kwh sensor, only a total_power_*_t1_kwh sensor. The total_power_*_kwh has been added.
  • Later, we removed duplicate sensors when no more than one tariff sensor was exposed.
  • Effectively, this removed a sensor and added a new one while loosing data.

This does not fix the issue when the user already has installed 2023.12, because the new sensor is already created. The data is not lost, but can't be accessed. We have to find another solution for that.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@frenck frenck self-assigned this Dec 7, 2023
@frenck frenck added this to the 2023.12.1 milestone Dec 8, 2023
Copy link
Contributor Author

@DCSBL DCSBL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes by @frenck approved 👍. Thanks!

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @DCSBL 👍

../Frenck

@frenck frenck merged commit 156dac3 into home-assistant:dev Dec 8, 2023
23 checks passed
@DCSBL DCSBL deleted the homewizard-t1-migration branch December 8, 2023 08:42
frenck added a commit that referenced this pull request Dec 8, 2023
Co-authored-by: Franck Nijhof <git@frenck.dev>
@frenck frenck mentioned this pull request Dec 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HomeWizard and 2023.12
2 participants