Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Aftership import issue when entry already exists #105476

Merged
merged 3 commits into from Dec 11, 2023
Merged

Remove Aftership import issue when entry already exists #105476

merged 3 commits into from Dec 11, 2023

Conversation

joostlek
Copy link
Member

Proposed change

Remove Aftership import issue when entry already exists

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot marked this pull request as draft December 11, 2023 08:40
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@joostlek joostlek marked this pull request as ready for review December 11, 2023 08:47
frenck
frenck approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @joostlek 👍

../Frenck

@frenck frenck added this to the 2023.12.2 milestone Dec 11, 2023
@frenck frenck merged commit 32681ac into home-assistant:dev Dec 11, 2023
23 checks passed
@joostlek joostlek deleted the aftership-already-exists-issue branch December 11, 2023 11:38
Bre77 pushed a commit to Bre77/core that referenced this pull request Dec 12, 2023
@joostlek @Bre77
Remove Aftership import issue when entry already exists (home-assista…
be75bd3 
…nt#105476)
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

@emontnemery emontnemery Awaiting requested review from emontnemery

Assignees
No one assigned
Labels
bugfix cherry-picked cla-signed has-tests integration: aftership Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2023.12.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joostlek @frenck @emontnemery